Re: [PATCH v2 3/5] lib/cmdline: Allow get_options() to take 0 to validate the input

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Fri, Jan 22, 2021 at 12:15:20PM +0100, Bartosz Golaszewski wrote:
> On Wed, Jan 20, 2021 at 10:45 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:

...

> > + *     When @nints is 0, the function just validates the given @str and
> > + *     returns amount of parseable integers as described below.
> 
> I'm not a native English speaker but it sounds like this should be
> "returns the amount".

Sounds reasonable. Fixed for v3.

...

> > +       bool validate = nints == 0;
> 
> bool validate = (nints == 0) would be clearer IMO.

I don't see the benefit, but I have changed.

...

> Same as the other patch - just put the formatting strings into the messages.

Okay, I changed.


Thanks for review!

-- 
With Best Regards,
Andy Shevchenko