Re: [PATCH v2] gpiolib: Disallow identical line names in the same chip

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

On Wed, Jan 6, 2021 at 12:24 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Tue, Jan 5, 2021 at 6:28 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Jan 5, 2021 at 10:31 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > > We need to make this namespace hierarchical: at least do not
> > > allow two lines on the same chip to have the same name, this
> > > is just too much flexibility. If we name a line on a chip,
> > > name it uniquely on that chip.
> > >
> > > This does not affect device tree and other gpiochips that
> > > get named from device properties: the uniqueness
> > > per-chip however affect all hotplugged devices such as
> > > GPIO expanders on USB.
> >
> > ...
> >
> > > [Dropped warning for globally unique]
> >
> > > + * - Allow names to not be globally unique but warn about it.
> >
> > Is the second part of this sentence still ture?
> > Maybe I missed a warning we are talking about here?
>
> Oops old text, Bartosz if this looks OK otherwise can you fix
> this when applying? (Just delete that line.)
>
> Yours,
> Linus Walleij

I can do it alright. But in the context of user-space I think this
doesn't really change anything. DT users still can use non-unique
names and libgpiod still has to account for that if the API is to be
considered correct. Is this change really useful? How does it affect
ACPI users that already define non-unique names?

Bartosz