Re: [PATCH] gpio: Skip over NULL and (empty string) line names

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Dec 18, 2020 at 6:05 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Tue, Dec 15, 2020 at 2:41 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> >
> > The core will warn if we try to assign the name ''
> > (empty string) to two lines. Actively ignore NULL
> > and empty string in the name assignment loop.
>
> > +               if (!gc->names[i] || !strlen(gc->names[i]))
>
> > +               if (!gc->names[i] || !strlen(gc->names[i]))
>
> > +               if (!names[i] || !strlen(names[i]))
>
> Can we replace strlen() calls by a simple check of the first byte?
>
> names[i][0]

Unfinished example...

        if (!names[i] || names[i][0] == '\0')


-- 
With Best Regards,
Andy Shevchenko