Re: [RFC PATCH] pinctrl: add helper to expose pinctrl state in debugfs

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Dec 16, 2020 at 12:42 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
> On Tue, Dec 15, 2020 at 09:39:18PM +0200, Andy Shevchenko wrote:
> > On Tue, Dec 15, 2020 at 9:36 PM Andy Shevchenko
> > <andy.shevchenko@xxxxxxxxx> wrote:
> > > On Mon, Dec 14, 2020 at 11:44 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
> > > > On Mon, Dec 14, 2020 at 07:55:12PM +0200, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > With regards to parent directory, I did discover there is
> > > > debugfs_lookup(), so I can get the dentry for "pinctrl" and create new
> > > > subdirectory inside of it.  This is the structure now:
> > > >
> > > > /sys/kernel/debug/pinctrl/pinctrl_state/ocp:P2_35_pinmux/state
> > > > /sys/kernel/debug/pinctrl/pinctrl_state/ocp:P2_34_pinmux/state
> > > > /sys/kernel/debug/pinctrl/pinctrl_state/ocp:P2_33_pinmux/state
> > > > /sys/kernel/debug/pinctrl/pinctrl_state/ocp:P2_32_pinmux/state
> > > > etc..
> >
> > Missed part to comment.
> >
> > I was talking about
> >
> > /sys/kernel/debug/pinctrl/<$PINCTRL>/mux/<$PIN> (maybe folder, maybe node)
>
> Thanks for the example.
>
> What would the value be "<$PINCTRL>"?  The name of the driver?

The name of the device instance. This is already done in the pin control code.

> The "ocp:Px_yy_pinmux" directory name comes from dev_name(dev). Is that
> the name you were referencing in "<$PIN>"?

No, the <$PIN> is an actual pin on this controller. However, I think
we probably don't need this, just supply it as tuple of the parameters
to be set: like
echo $PIN $STATE > .../<$PINCTRL>/mux or alike.

-- 
With Best Regards,
Andy Shevchenko