Re: [PATCH v3 11/12] mfd: bd9571mwv: Make the driver more generic

["Vaittinen, Matti" <Matti.Vaittinen@xxxxxxxxxxxxxxxxx>]

On Wed, 2020-12-16 at 09:00 +0000, Lee Jones wrote:
> On Wed, 16 Dec 2020, Vaittinen, Matti wrote:
> 
> > On Wed, 2020-12-16 at 16:37 +0900, Yoshihiro Shimoda wrote:
> > > From: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> > > 
> > > Since the driver supports BD9571MWV PMIC only,
> > > this patch makes the functions and data structure become more
> > > generic
> > > so that it can support other PMIC variants as well.
> > > 
> > > Signed-off-by: Khiem Nguyen <khiem.nguyen.xt@xxxxxxxxxxx>
> > > [shimoda: rebase and refactor]
> > > Signed-off-by: Yoshihiro Shimoda <
> > > yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > 
> > Reviewed-by: Matti Vaittinen <matti.vaittinen@xxxxxxxxxxxxxxxxx>
> 
> Please place any *-by tags *after* the other comments.
> 
> Fortunately, the first one below was still on my screen, else I would
> have stopped reading here.
> 

Good point. I'd better keep that on mind. Although missing stuff after
a Reviewed-by is not that fatal ;)


> > > ---
> > >  drivers/mfd/bd9571mwv.c       | 95 +++++++++++++++++++++++++++
> > > ----
> > > ------------
> > >  include/linux/mfd/bd9571mwv.h | 18 ++------
> > >  2 files changed, 63 insertions(+), 50 deletions(-)