Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/10/2020 9:25 PM, Thomas Gleixner wrote:
No driver has any business with the internals of an interrupt
descriptor. Storing a pointer to it just to use yet another helper at the
actual usage site to retrieve the affinity mask is creative at best. Just
because C does not allow encapsulation does not mean that the kernel has no
limits.

Retrieve a pointer to the affinity mask itself and use that. It's still
using an interface which is usually not for random drivers, but definitely
less hideous than the previous hack.

Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
---
  drivers/net/ethernet/mellanox/mlx5/core/en.h      |    2 +-
  drivers/net/ethernet/mellanox/mlx5/core/en_main.c |    2 +-
  drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c |    6 +-----
  3 files changed, 3 insertions(+), 7 deletions(-)


Reviewed-by: Tariq Toukan <tariqt@xxxxxxxxxx>

Thanks.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux