Re: [PATCH v5 12/21] riscv: Add Canaan Kendryte K210 reset controller

[Damien Le Moal <Damien.LeMoal@xxxxxxx>]

Hi Philipp,

On Tue, 2020-12-08 at 12:44 +0100, Philipp Zabel wrote:
[...]
> > diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> > index 07d162b179fc..ded44889484f 100644
> > --- a/drivers/reset/Kconfig
> > +++ b/drivers/reset/Kconfig
> > @@ -82,6 +82,16 @@ config RESET_INTEL_GW
> >  	  Say Y to control the reset signals provided by reset controller.
> >  	  Otherwise, say N.
> >  
> > 
> > 
> > 
> > +config RESET_K210
> > +	bool "Reset controller driver for Canaan Kendryte K210 SoC"
> > +	depends on RISCV && SOC_CANAAN && OF
> 
> Please enable compile-testing on other architectures, for example:
> 
> 	depends on ((RISCV && SOC_CANAAN) || COMPILE_TEST) && OF
> 
> Are there non-RISCV SOC_CANAAN devices for which this driver shouldn't
> be compiled?
> If not, you could you drop the RISCV dependency without loss of
> information.

I added COMPILE_TEST. I also removed the RISCV dependency since SOC_CANAAN
already depend on it (due to the SOC_EARLY_INIT_DECLARE() use in the sysctl
driver). Stricktly speaking, I think we could also remove the SOC_CANAAN
dependency for the reset driver, but I do not really see the point since it is
cannot be used for any other SoC.

I addressed all of your other comments.

Thanks !


-- 
Damien Le Moal
Western Digital