Re: [PATCH v1] pinctrl: intel: Actually disable Tx and Rx buffers on GPIO request

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Dec 7, 2020 at 7:07 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Mon, Dec 7, 2020 at 8:02 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Mistakenly the buffers (input and output) become together enabled for a little
> > period of time during GPIO request. This is problematic, because instead of
> > initial motive to disable them in the commit af7e3eeb84e2
> > ("pinctrl: intel: Disable input and output buffer when switching to GPIO"),
> > the driven value on the pin, which might be used as an IRQ line, brings
> > firmware of some touch pads in an awkward state that needs a full power off
> > to recover. Fix this by, as stated in a culprit commit, disabling the buffers.
>
> Linus, since we are at rc7 I'm not going to send a PR for this single
> fix (I truly do not expect anything to come). Please, proceed as usual
> (either to v5.10 or to v5.11 cycle, there is not much difference b/c
> culptin is sitting in v5.9).

OK no problem, I applied the patch directly for fixes so we get it in ASAP.

Yours,
Linus Walleij