On 12/7/20 12:16 PM, Mika Westerberg wrote:
On Mon, Dec 07, 2020 at 07:59:40PM +0200, Andy Shevchenko wrote:Mistakenly the buffers (input and output) become together enabled for a little period of time during GPIO request. This is problematic, because instead of initial motive to disable them in the commit af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer when switching to GPIO"), the driven value on the pin, which might be used as an IRQ line, brings firmware of some touch pads in an awkward state that needs a full power off to recover. Fix this by, as stated in a culprit commit, disabling the buffers. Fixes: af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer when switching to GPIO") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210497 Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
On the initial device where I reported the problem, and with the battery disconnected to make sure there's no EC issue, this patch restores the touchpad functionality.
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
