Re: [PATCH] gpio: omap: handle deferred probe with dev_err_probe() for gpiochip_add_data()

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

On Wed, Nov 18, 2020 at 3:31 PM Grygorii Strashko
<grygorii.strashko@xxxxxx> wrote:
>
> The gpiochip_add_data() may return -EPROBE_DEFER which is not handled
> properly by TI GPIO driver and causes unnecessary boot log messages.
>
> Hence, add proper deferred probe handling with new dev_err_probe() API.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>
> ---
>  drivers/gpio/gpio-omap.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index f7ceb2b11afc..41952bb818ad 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -1049,11 +1049,8 @@ static int omap_gpio_chip_init(struct gpio_bank *bank, struct irq_chip *irqc)
>         irq->first = irq_base;
>
>         ret = gpiochip_add_data(&bank->chip, bank);
> -       if (ret) {
> -               dev_err(bank->chip.parent,
> -                       "Could not register gpio chip %d\n", ret);
> -               return ret;
> -       }
> +       if (ret)
> +               return dev_err_probe(bank->chip.parent, ret, "Could not register gpio chip\n");
>
>         ret = devm_request_irq(bank->chip.parent, bank->irq,
>                                omap_gpio_irq_handler,
> --
> 2.17.1
>

Now applied. Thanks!

Bartosz