Re: [PATCH] gpio: mvebu: fix potential user-after-free on probe

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hi Baruch,

On Mon, Nov 30, 2020 at 03:55:28PM +0200, Baruch Siach wrote:
> On Mon, Nov 30 2020, Uwe Kleine-König wrote:
> > On Mon, Nov 30, 2020 at 03:33:23PM +0200, Baruch Siach wrote:
> >> When mvebu_pwm_probe() fails IRQ domain is not released. Move
> >> mvebu_pwm_probe() before IRQ domain registration.
> >
> > And now if something with IRQ domain registration fails the pwm stuff
> > isn't freed?
> 
> As far as I can see mvebu_pwm_probe() uses devres exclusively to
> allocate resources.

there is no devm magic in pwmchip_add().

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature