> From: Louis Rannou <louis@xxxxxxxxx> > Sent: Friday, November 27, 2020 11:06 PM > Subject: [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG > settings > > According to the imx7ulp reference manual, the LSB refers to PS (Pull Select Field) > and the 2nd to PE (Pull-up Enable). > > Signed-off-by: Louis Rannou <louis.rannou@xxxxxxxxx> The title may be better to be: dt-bindings: pinctrl: imx7ulp: fix incorrect pin CONFIG Otherwise: Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx> Regards Aisheng > --- > .../devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt > b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt > index bfa3703a7446..50ae260581eb 100644 > --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt > @@ -33,7 +33,8 @@ PAD_CTL_ODE (1 << 5) > PAD_CTL_PUSH_PULL (0 << 5) > PAD_CTL_SRE_SLOW (1 << 2) > PAD_CTL_SRE_STD (0 << 2) > -PAD_CTL_PE (1 << 0) > +PAD_CTL_PE (1 << 1) > +PAD_CTL_PS (1 << 0) > > Examples: > #include "imx7ulp-pinfunc.h" > -- > 2.29.2