Re: [PATCH v3] mxc: gpio: Convert the driver to DT-only

[Fabio Estevam <festevam@xxxxxxxxx>]

Hi Andy,

On Tue, Nov 17, 2020 at 7:38 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:

> I like the result!
> FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thanks for the suggestions and review.

I noticed that I will have to change one line:

> > -       if (mxc_gpio_hwtype == IMX21_GPIO) {
> > +       if (port->hwdata == &imx1_imx21_gpio_hwdata) {

as the original condition was only true for the "mx21" type of GPIO
and now evaluates true for both imx1 and imx21.

I will change this to:

-       if (mxc_gpio_hwtype == IMX21_GPIO) {
+       if (of_device_is_compatible(np, "fsl,imx21-gpio")) {

to keep the original logic and send a v4.

Thanks