Re: [PATCH v1] pinctrl: merrifield: Set default bias in case no particular value given

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Thu, Nov 12, 2020 at 10:06:50AM +0200, Mika Westerberg wrote:
> On Wed, Nov 11, 2020 at 02:06:05PM +0200, Andy Shevchenko wrote:
> > When GPIO library asks pin control to set the bias, it doesn't pass
> > any value of it and argument is considered boolean (and this is true
> > for ACPI GpioIo() / GpioInt() resources, by the way). Thus, individual
> > drivers must behave well, when they got the resistance value of 1 Ohm,
> > i.e. transforming it to sane default.
> > 
> > In case of Intel Merrifield pin control hardware the 20 kOhm sounds plausible
> > because it gives a good trade off between weakness and minimization of leakage
> > current (will be only 50 uA with the above choice).
> > 
> > Fixes: 4e80c8f50574 ("pinctrl: intel: Add Intel Merrifield pin controller support")
> > Depends-on: 2956b5d94a76 ("pinctrl / gpio: Introduce .set_config() callback for GPIO chips")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko