Re: [PATCH v5 08/17] gpiolib: Extract gpio_set_debounce_timeout() for internal use

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Nov 11, 2020 at 5:54 PM Mika Westerberg
<mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> On Wed, Nov 11, 2020 at 05:46:55PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 11, 2020 at 5:40 PM Mika Westerberg
> > <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> > > On Mon, Nov 09, 2020 at 10:53:23PM +0200, Andy Shevchenko wrote:

...

> > > Again I think mode variable is pretty useless here and does not improve
> > > readability.
> >
> > You mean something like
> >
> >     return gpio_set_config_with_argument_optional(desc,
> >                 PIN_CONFIG_INPUT_DEBOUNCE, debounce);
> >
> > is better?

Hmm... Not sure I can agree with this, but I can change.

-- 
With Best Regards,
Andy Shevchenko