On Mon, Nov 09, 2020 at 10:53:19PM +0200, Andy Shevchenko wrote: > Temporary variable that keeps mode allows to neat the code a bit. > It will also help for the future changes. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Not really sure if this is good change or not. Instead of constant you now introduce a useless variable just to get them to the same line. To me this looks better and reads easier: packed = pinconf_to_config_packed(PIN_CONFIG_PERSIST_STATE, !transitory); But not insisting so if GPIO maintainers are fine then no objections :)