On Tue, Nov 10, 2020 at 1:33 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > I just wanted to convert the driver to using simpler IDA API but ended up > quickly converting it to using regmap. Unfortunately I don't have the HW > to test it so marking the patches that introduce functional change as RFT > and Cc'ing the original author. > > v1 -> v2: > - add new regmap helper: regmap_assign_bits() > - fix lvl vs sel register access > - set value in direction_output callback > > v2 -> v3: > - drop the regmap helper from series > > Note: I didn't use the fancy method of offset calculation Andy and David > suggested because this series broke the driver according to Jan - let's > get it right before we modify it any more. I found a couple problems that > could maybe cause the crash. Jan: could you give it another spin? > > Bartosz Golaszewski (7): > gpio: exar: add a newline after the copyright notice > gpio: exar: include idr.h > gpio: exar: switch to a simpler IDA interface > gpio: exar: use a helper variable for &pdev->dev > gpio: exar: unduplicate address and offset computation > gpio: exar: switch to using regmap > gpio: exar: use devm action for freeing the IDA and drop remove() > > drivers/gpio/Kconfig | 1 + > drivers/gpio/gpio-exar.c | 154 +++++++++++++++++++-------------------- > 2 files changed, 77 insertions(+), 78 deletions(-) > > -- > 2.29.1 > Sorry for the noise, I noticed that I included Mark again when I started sending this series. Bartosz