Re: [PATCH v2] treewide: rework struct gpiod_line_bulk

[Kent Gibson <warthog618@xxxxxxxxx>]

On Wed, Oct 28, 2020 at 05:26:51PM +0100, Bartosz Golaszewski wrote:
> On Wed, Oct 28, 2020 at 4:03 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > On Wed, Oct 28, 2020 at 02:19:05PM +0100, Bartosz Golaszewski wrote:
> > > On Wed, Oct 28, 2020 at 10:39 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> > > >
> > > > On Tue, Oct 27, 2020 at 10:17:15AM +0100, Bartosz Golaszewski wrote:
> > > > > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > > > >
> > > >
> > > > Subject should be prefixed with [libgpiod] according to the README ;).
> > > >
> > >
> > > Oh come on! :)
> > >
> > > [snip]
> > >
> > > >
> > > > If you replace the gpiod_line_bulk_iter_foreach_line() here with
> > > > manually looping over the bulk lines then everything from A to B above
> > > > can be dropped.
> > > >
> > >
> > > Something is telling me that dedicated iterators are more elegant. But
> > > I guess we can do everything manually for now and see about that
> > > later. Fair enough, I'll drop it.
> > >
> >
> > Good thing I'm here to let you know that little voice is wrong :).
> >
> > I've got a couple of commits in my working tree[1] that apply to your
> > patch and drop the iters as I've suggested if you'd like to compare.
> >
> > Cheers,
> > Kent.
> >
> > [1] https://github.com/warthog618/libgpiod/commits/for-v2
> 
> Would you mind if I squashed those changes into my patch?
> 

Not at all.

Cheers,
Kent.