On Mon, 19 Oct 2020, at 15:20, Billy Tsai wrote: > GPIO_T is mapped to the most significant byte of input/output mask, and > the byte in "output" mask should be 0 because GPIO_T is input only. All > the other bits need to be 1 because GPIO_Q/R/S support both input and > output modes. > > Signed-off-by: Billy Tsai <billy_tsai@xxxxxxxxxxxxxx> Good catch, thanks Billy. Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>