On Sun, Sep 27, 2020 at 7:57 PM Sean Wang <sean.wang@xxxxxxxxxx> wrote: > v2 seems the same with v1 or I was missing something. > > I just thought we call devm_ioremap_release to explicitly to free > resource when a certain failure occurs after > devm_ioremap_resource? What is the semantics around mtk_build_eint()? If it is called on the probe path no explicit free:ing is necessary: anytime probe() exits with an error code, any devm* resources will be free:ed. Yours, Linus Walleij