Re: [PATCH v3] gpiolib: Fix line event handling in syscall compatible mode

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Sep 17, 2020 at 12:04 PM Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
> On Thu, Sep 17, 2020 at 9:59 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> > On Tue, Sep 15, 2020 at 03:58:16PM +0300, Andy Shevchenko wrote:
> > > The introduced line event handling ABI in the commit
> > >
> > >   61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
> > >
> > > missed the fact that 64-bit kernel may serve for 32-bit applications.
> > > In such case the very first check in the lineevent_read() will fail
> > > due to alignment differences.
> > >
> > > To workaround this introduce lineevent_get_size() helper which returns actual
> > > size of the structure in user space.
> > >
> > > Fixes: 61f922db7221 ("gpio: userspace ABI for reading GPIO line events")
> > > Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> >
> > Tested-by: Kent Gibson <warthog618@xxxxxxxxx>
>
> Patch applied, thanks everyone for the patch and QA!

I'm also very happy for this fixup even though I didn't even comment
a single time, thanks so much folks! This is community at its best.

Yours,
Linus Walleij