Hello, The AST2600 pinctrl driver was missing support for bias control on the 1.8V GPIO pins, and in the process of resolving that I discovered a couple of other bugs that are fixed in the first two patches of the series. v2 Tweaks some of the debug output and adds Joel's Reviewed-by tags. v1 can be found here: https://lore.kernel.org/linux-gpio/20200909114312.2863675-1-andrew@xxxxxxxx/ Please review! Andrew Andrew Jeffery (3): pinctrl: aspeed: Format pinconf debug consistent with pinmux pinctrl: aspeed: Use the right pinconf mask pinctrl: aspeed-g6: Add bias controls for 1.8V GPIO banks drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c | 17 +++++++++++++++++ drivers/pinctrl/aspeed/pinctrl-aspeed.c | 8 ++++---- 2 files changed, 21 insertions(+), 4 deletions(-) -- 2.25.1