On Tue, Sep 08, 2020 at 03:12:25PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > > We don't need to specify any ranges when allocating IDs so we can switch > to ida_alloc() and ida_free() instead of the ida_simple_ counterparts. > > ida_simple_get(ida, 0, 0, gfp) is equivalent to > ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to > ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID > larger than INT_MAX. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > --- > drivers/gpio/gpiolib.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index 80137c1b3cdc..97f76334ec7e 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -426,7 +426,7 @@ static void gpiodevice_release(struct device *dev) > struct gpio_device *gdev = dev_get_drvdata(dev); > > list_del(&gdev->list); > - ida_simple_remove(&gpio_ida, gdev->id); > + ida_free(&gpio_ida, gdev->id); > kfree_const(gdev->label); > kfree(gdev->descs); > kfree(gdev); > @@ -537,7 +537,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, > gc->of_node = gdev->dev.of_node; > #endif > > - gdev->id = ida_simple_get(&gpio_ida, 0, 0, GFP_KERNEL); > + gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL); > if (gdev->id < 0) { > ret = gdev->id; > goto err_free_gdev; > @@ -705,7 +705,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data, > err_free_descs: > kfree(gdev->descs); > err_free_ida: > - ida_simple_remove(&gpio_ida, gdev->id); > + ida_free(&gpio_ida, gdev->id); > err_free_gdev: > /* failures here can mean systems won't boot... */ > pr_err("%s: GPIOs %d..%d (%s) failed to register, %d\n", __func__, > -- > 2.26.1 > -- With Best Regards, Andy Shevchenko