> Subject: Re: [PATCH V3 3/3] pinctrl: imx: Support building i.MX pinctrl core > driver as module > > On Tue, Sep 8, 2020 at 9:20 AM Anson Huang <Anson.Huang@xxxxxxx> > wrote: > > > # SPDX-License-Identifier: GPL-2.0-only config PINCTRL_IMX > > - bool > > + tristate "IMX pinctrl core driver" > > + depends on OF > > select GENERIC_PINCTRL_GROUPS > > select GENERIC_PINMUX_FUNCTIONS > > select GENERIC_PINCONF > > I don't see why you need to make this option user-visible when it is already > selected by the drivers that need it. Wouldn't it be enough to change the 'bool' > to 'tristate' without adding a prompt? Make sense, so it is same for PINCTRL_IMX_SCU, right? Anson