[libgpiod] Integer overflow in C++ binding on 32bit systems causes wrong event timestamps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

I found a bug in the c++ bindings of libgpiod that affects 32bit systems.

Observation:

Only the c++ bindings lib is affected. For input events, the time stamp
delivered in the event object is wrong. Instead of providing a complete
"system time", it delivers time stamps of of a range "-2.1"...+2.1 seconds
(which relates to the time stamp range of a signed 32bit value, in
nanoseconds).

Cause:

The bug is in line 219 of file "/tree/bindings/cxx/line.cpp":

event.ts.tv_nsec + (event.ts.tv_sec * 1000000000));

"event.ts.tv_sec" is of type signed long, which is 32 bit on my device. Thus,
that multiplication to convert total seconds of a system time to nanoseconds
causes an overflow.

Fix:

There should be a cast to uint64_t before the multiplication.

Thank you for fixing this!

Regards,
Florian

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux