On Fri, Sep 04, 2020 at 07:21:41PM +0200, Hans de Goede wrote: > One some devices the GPIO should output the inverted value from what > Fixes: a7d4b171660c ("Input: goodix - add support for getting IRQ + reset GPIOs on Cherry Trail devices") Hans, a side note. Can you clean up that driver using ACPI GPIO quirks and the idea that IRQ line will be retrieved in client->irq? I recently submit a patch against BT Intel driver [1] where similar approach is utilized. [1]: https://lore.kernel.org/linux-bluetooth/20200903184850.53055-1-andriy.shevchenko@xxxxxxxxxxxxxxx/T/ -- With Best Regards, Andy Shevchenko