Re: [PATCH] pinctrl: nomadik: Fix pull direction debug info

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Thu, Aug 6, 2020 at 5:53 PM Andrew Halaney <ajhalaney@xxxxxxxxx> wrote:

> The nomadik pinctrl hardware doesn't have any way to
> determine if the active pull is up or down. Reading
> the bit currently used to report if the pull is up/down
> indicates if the gpio input is reading high or low, it
> doesn't reflect the pull state.
>
> For this reason change the output from "pull up"/"pull down" to
> "pull enabled". This avoids confusing developers who were using
> the output to determine what the pull state is.
>
> Signed-off-by: Andrew Halaney <ajhalaney@xxxxxxxxx>

Patch applied. It's clearly better like this. A plain bug.

Do you think we can fix it properly by reading both the
DATS and DATC registers  to do the inverse of what
__nmk_gpio_set_pull() does and give a proper readout
of pull up/down?

Out of curiosity: what hardware are you testing this on?

Yours,
Linus Walleij