RE: [PATCH v2 5/8] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC rtd1295

[TY_Chang[張子逸] <tychang@xxxxxxxxxxx>]

Hi Rob,

Thanks for the review.

> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: Friday, July 17, 2020 3:57 AM
> To: TY_Chang[張子逸] <tychang@xxxxxxxxxxx>
> Cc: linux-realtek-soc@xxxxxxxxxxxxxxxxxxx; afaerber@xxxxxxx;
> linus.walleij@xxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 5/8] dt-bindings: pinctrl: realtek: Add Realtek DHC SoC
> rtd1295
> 
> On Thu, Jul 16, 2020 at 10:33:35AM +0800, TY Chang wrote:
> > Add device tree binding Documentation for rtd1295 pinctrl driver.
> >
> > Signed-off-by: TY Chang <tychang@xxxxxxxxxxx>
> > ---
> >  .../pinctrl/realtek,rtd1295-pinctrl.yaml      | 121 ++++++++++++++++++
> >  1 file changed, 121 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctrl.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctrl.ya
> > ml
> > b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctrl.ya
> > ml
> > new file mode 100644
> > index 000000000000..8cd6cfa2282e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/realtek,rtd1295-pinctr
> > +++ l.yaml
> > @@ -0,0 +1,121 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devicetree.org/schemas/pinctrl/realtek,rtd1295-pinctrl.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Realtek DHC RTD1295 pin control
> > +
> > +maintainers:
> > +  - Andreas Farber <afaerber@xxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - realtek,rtd1295-iso-pinctrl
> > +      - realtek,rtd1295-sb2-pinctrl
> > +      - realtek,rtd1295-disp-pinctrl
> > +      - realtek,rtd1295-cr-pinctrl
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +#PIN CONFIGURATION NODES
> > +patternProperties:
> > +  '-pins$':
> > +    type: object
> > +    description:
> > +      Pinctrl node's client devices use subnodes for desired pin
> configuration.
> > +      Client device subnodes use below standard properties.
> > +    allOf:
> > +      - $ref: "/schemas/pinctrl/pincfg-node.yaml"
> > +
> > +    properties:
> > +      groups:
> > +        items:
> > +          enum: [ iso_gpio_0, iso_gpio_1, iso_gpio_2, iso_gpio_3,
> iso_gpio_4,
> > +          iso_gpio_5, hdmi_hpd, iso_gpio_7, ir_rx, ir_tx, ur0_rx,
> > +          ur0_tx, ur1_rx, ur1_tx, ur1_cts_n, ur1_rts_n, i2c_scl_0,
> > +          i2c_sda_0, i2c_scl_1, i2c_sda_1, i2c_scl_6, iso_gpio_21,
> > +          iso_gpio_22, iso_gpio_23, iso_gpio_24, iso_gpio_25,
> > +          i2c_sda_6, etn_led_link, etn_led_rxtx, nat_led_0,
> > +          nat_led_1, nat_led_2, nat_led_3, iso_gpio_33,
> > +          iso_gpio_34, pwm_23_loc0, pwm_01_loc0, pwm_23_loc1,
> > +          pwm_01_loc1, ejtag_avcpu_loc, ur2_loc, i2c0, i2c1,
> > +          i2c6, uart0, uart1, uart2_0, uart2_1, gpio_0, gpio_1,
> > +          gpio_2, gpio_3, gpio_4, gpio_5, gpio_6, gpio_7, gpio_8,
> > +          gpio_9, tp1_sync, i2c_scl_4, i2c_sda_4, i2c_scl_5,
> > +          i2c_sda_5, usb_id, sensor_cko_0, sensor_cko_1, sensor_rst,
> > +          sensor_stb_0, sensor_stb_1, tp0_data, tp0_clk, tp0_valid,
> > +          tp0_sync, tp1_data, tp1_clk, tp1_valid, rgmii0_txc,
> > +          rgmii0_tx_ctl,rgmii0_txd_0, rgmii0_txd_1, rgmii0_txd_2,
> > +          rgmii0_txd_3, rgmii0_rxc, rgmii0_rx_ctl, rgmii0_rxd_0,
> > +          rgmii0_rxd_1, rgmii0_rxd_2, rgmii0_rxd_3, rgmii0_mdio,
> > +          rgmii0_mdc, rgmii1_txc, rgmii1_tx_ctl, rgmii1_txd_0,
> > +          rgmii1_txd_1, rgmii1_txd_2, rgmii1_txd_3, rgmii1_rxc,
> > +          rgmii1_rx_ctl, rgmii1_rxd_0, rgmii1_rxd_1, rgmii1_rxd_2,
> > +          rgmii1_rxd_3, hif_loc, ejtag_scpu_loc, sf_en, tp0_loc,
> > +          tp1_loc, spdif, dmic_clk, dmic_data, ao_lrck, ao_bck,
> > +          aock, ao_sd_0, ao_sd_1, ao_sd_2, ao_sd_3, nf_cle,
> > +          nf_ale, nf_rd_n, nf_wr_n, nf_rdy, nf_dd_7, nf_dd_6,
> > +          nf_dd_5, nf_dd_4, nf_dd_3, nf_dd_2, nf_dd_1, nf_dd_0,
> > +          nf_dqs, nf_ce_n_0, nf_ce_n_1, emmc_dd_sb, mmc_cmd,
> > +          mmc_clk, mmc_wp, mmc_cd, mmc_data_0, mmc_data_1,
> > +          mmc_data_2, mmc_data_3, sdio_cmd, sdio_clk, sdio_data_0,
> > +          sdio_data_1, sdio_data_2, sdio_data_3, pcie_clkreq_0,
> > +          pcie_clkreq_1, prob_0, prob_1, prob_2, prob_3, sdio_loc ]
> > +        minItems: 1
> > +
> > +      function:
> > +        enum: [ gpio, acpu_ejtag_loc_iso, edp_hpd, etn_led, i2c0, i2c1,
> i2c6,
> > +        ir_rx, ir_tx, nat_led, pwm_0, pwm_1, rtc, sc, standby_dbg,
> > +        uart0, uart1, uart2_0, uart2_1, pwm_01_loc0_normal,
> > +        pwm_23_loc0_normal, pwm_01_loc0_open_drain,
> pwm_23_loc0_open_drain,
> > +        pwm_01_loc1_normal, pwm_23_loc1_normal,
> pwm_01_loc1_open_drain,
> > +        pwm_23_loc1_open_drain, acpu_ejtag_loc_nf, ai, dc_fan_sensor,
> > +        eth_gpy, gspi, i2c2, i2c3, i2c4, i2c5, nand, rgmii,
> scpu_ejtag_loc_gpio,
> > +        sensor_cko_output, spi, test_loop_dis, tp0_loc_rgmii0_tx,
> tp0_loc_tp0,
> > +        tp0_loc_tp1, tp1_loc_rgmii0_rx, tp1_loc_tp0, tp1_loc_tp1,
> > +        usb_clock_output, hif_loc_misc, hif_loc_nf, scpu_ejtag_loc_cr, ao,
> > +        dmic, spdif_out, avcpu_ej, emmc, hif, nand, p2s, pcie, pll_test,
> > +        scpu_ejtag_loc_cr, sd_card, sdio_0, sdio_1 ]
> > +
> > +      drive-strength:
> > +        enum: [2, 4, 8]
> > +
> > +      bias-pull-down: true
> > +
> > +      bias-pull-up: true
> > +
> > +      bias-disable: true
> > +
> > +      input-schmitt-disable: true
> > +
> > +      input-schmitt-enable: true
> > +
> > +    required:
> > +      - groups
> > +      - function
> > +
> > +    additionalProperties: false
> 
> Also need top-level 'additionalProperties: false'.

I will add this in patch v3.

> 
> With that,
> 
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> 

Best Regards,
TYChang

> ------Please consider the environment before printing this e-mail.