Re: [PATCH] gpio: stmpe: Use irqchip template

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Jul 27, 2020 at 11:13 PM Serge Semin <fancer.lancer@xxxxxxxxx> wrote:

> Hmm, the GPIO-irq-chip setting are initialized after the GPIO-chip has been
> registered by calling the gpiochip_add_data() method earlier in this method.
> That means the IRQ-chip won't be created by the GPIOlib, which will introduce a
> bug. In order to fix the problem it's better to move the whole "if (irq > 0)
> {...}" clause to be executed before the gpiochip_add_data() function invocation.
>
> Though I could misunderstood something...

Ah what a mistake, thank you so much for looking through this patch and
spotting this! I sent a fix.

Yours,
Linus Walleij