Re: [PATCH] gpio: max732x: Use irqchip template

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jul 24, 2020 at 1:50 PM Sam Protsenko
<semen.protsenko@xxxxxxxxxx> wrote:
> On Tue, 21 Jul 2020 at 12:54, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> > On Sun, Jul 19, 2020 at 6:34 PM Sam Protsenko
> > <semen.protsenko@xxxxxxxxxx> wrote:

...

> > Just that really, that the IRQs happen as before.

> Just tested it on my MAX7325 board [1], by adding gpio-keys and
> gpio-leds to BBB dts [2]. Alas, the patch seems to be breaking IRQs.
> Before the patch, I can see gpio-buttons appear in /proc/interrupts
> and dmesg is clear of errors. After applying the patch, no gpio-keys
> appear in /proc/interrupts and dmesg is reporting errors like this:
>
>     irq: no irq domain found for max7325@68 !
>
> This is probably because the patch is setting gpio_chip structure
> fields after devm_gpiochip_add_data() was executed.

...

> I didn't check if it's a correct fix, so the diff above is only to
> check the idea.

I checked pca953x and there the same trick has been applied. In my
setup that driver works. I think it's the right way to go.

-- 
With Best Regards,
Andy Shevchenko