RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

[Srinivas Neeli <sneeli@xxxxxxxxxx>]

Hi Linus,

Thanks for the review

> -----Original Message-----
> From: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Sent: Friday, July 24, 2020 2:52 PM
> To: kernel test robot <lkp@xxxxxxxxx>
> Cc: Srinivas Neeli <sneeli@xxxxxxxxxx>; Bartosz Golaszewski
> <bgolaszewski@xxxxxxxxxxxx>; Michal Simek <michals@xxxxxxxxxx>;
> Shubhrajyoti Datta <shubhraj@xxxxxxxxxx>; Srinivas Goud
> <sgoud@xxxxxxxxxx>; kbuild-all@xxxxxxxxxxxx; open list:GPIO SUBSYSTEM
> <linux-gpio@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; git
> <git@xxxxxxxxxx>
> Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support
> 
> On Fri, Jul 24, 2020 at 6:12 AM kernel test robot <lkp@xxxxxxxxx> wrote:
> 
> >    drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe':
> >    drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member
> named 'of_gpio_n_cells'
> >      638 |  chip->gc.of_gpio_n_cells = cells;
> >          |          ^
> > >> drivers/gpio/gpio-xilinx.c:639:10: error: 'struct gpio_chip' has no
> member named 'of_xlate'
> >      639 |  chip->gc.of_xlate = xgpio_xlate;
> >          |          ^
> 
> This is probably because your driver needs:
> 
> depends on OF_GPIO
> 
> in KConfig
> 
I will address in v3.

> Yours,
> Linus Walleij