Re: [PATCH v2] gpio: crystalcove: Use irqchip template

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Jul 22, 2020 at 11:56 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> On 7/21/20 5:39 PM, Andy Shevchenko wrote:
> > On Tue, Jul 21, 2020 at 04:01:53PM +0200, Linus Walleij wrote:
> >> This makes the driver use the irqchip template to assign
> >> properties to the gpio_irq_chip instead of using the
> >> explicit calls to gpiochip_irqchip_add_nested() and
> >> gpiochip_set_nested_irqchip(). The irqchip is instead
> >> added while adding the gpiochip.
> >
> > Took this version instead.
> >
> > I dunno if Hans can come with some comments / testing results, I would like to
> > send a PR today or tomorrow.
>
> Sorry for being a bit slow with testing this.
>
> I've given this patch a test-run on a machine with the
> PMIC the driver is for and with the caveat that I've not
> actually tested the GPIO IRQ functionality, since that
> does not seem to be used on any machines, I see no adverse
> side effects from this patch, so it is:
>
> Tested-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Thank you, Hans! It seems we also don't have such a reference design
which uses PMIC GPIOs for IRQ.

P.S. Does wcove case similar?

-- 
With Best Regards,
Andy Shevchenko