Re: [PATCH v4] pinctrl: core: print gpio in pins debugfs file

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Jul 22, 2020 at 11:48 AM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Wed, Jul 22, 2020 at 1:29 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
> >
> > If there is a gpio range mapping for the pin, then print out the gpio
> > chip and line index for the pin in the debugfs 'pins' file with the
> > format: "[line-index]:[gpio-label]"
> >
> > Here is an example output on the BeagleBoard.org PocketBeagle (AM3358):
> > /sys/kernel/debug/pinctrl/44e10800.pinmux-pinctrl-single/pins
> >
> > pin 25 (PIN25) 25:gpio-32-63 44e10864 00000037 pinctrl-single
> > pin 26 (PIN26) 26:gpio-32-63 44e10868 00000037 pinctrl-single
> > pin 27 (PIN27) 27:gpio-32-63 44e1086c 00000037 pinctrl-single
> > pin 28 (PIN28) 0:N/A 44e10870 00000036 pinctrl-single
> > pin 29 (PIN29) 0:N/A 44e10874 00000006 pinctrl-single

Though one more nit, I have just realized, perhaps '0:?' would be
better, because GPIO library uses '?' in cases of unknown labels or
so.
I guess no need to resend (but if you wish you may do, with my tag
included) and we may wait for Linus and Bart to comment.

> > pin 30 (PIN30) 28:gpio-32-63 44e10878 00000027 pinctrl-single
> > pin 31 (PIN31) 29:gpio-32-63 44e1087c 00000037 pinctrl-single
> > pin 32 (PIN32) 30:gpio-32-63 44e10880 00000037 pinctrl-single
> > pin 33 (PIN33) 31:gpio-32-63 44e10884 00000037 pinctrl-single
> > pin 34 (PIN34) 0:gpio-64-95 44e10888 00000037 pinctrl-single
> > pin 35 (PIN35) 1:gpio-64-95 44e1088c 00000037 pinctrl-single
> >
>
> This variant looks good enough to me, thanks! FWIW,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>


-- 
With Best Regards,
Andy Shevchenko