Re: [PATCH] gpio: fixed some coding style issues in gpiolib files

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Tue, Jul 21, 2020 at 4:21 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
>
> On Tue, Jul 21, 2020 at 2:04 PM Abanoub Sameh
> <abanoubsameh@xxxxxxxxxxxxxx> wrote:
> >
> > So I only need to write some commit message like my first patch,
> > and I need to include the subsystem and also the file name.
> >
> > so it should be like this for example:
> >
> > gpio: crystalcove.c: fixed some coding style issues
>
> Better subject please, something like "Replace unsigned with unsigned int".
>
> > This patch make the code more consistent and uniform
>
> Something better, please.
> Like: "The unsigned type is slightly ambiguous to read, switch to
> explicit unsigned int."
>
> >
> > Signed-off-by ...
> >
> > Shall I resend all patches?
>
> Yes, and don't forget to bump a version number and provide a changelog
> (the latter after the cutter '---' line).
>
> >
> > thank you in advance for you help,
> > Abanoub Sameh
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko