Patch 1 makes sparse happy about locking and, in my opinion, improves readability, though increases LOC count. Patch 2 simplifies parser by using existing helpers. Patch 3 refactors loop in parser for better readability in my opinion. It might be you have different opinions about patches 1 and 3, we may discuss. Compile tested only. Andy Shevchenko (3): gpio: aggregator: Refactor ->{get,set}_multiple() to make Sparse happy gpio: aggregator: Simplify isrange() by using get_option() gpio: aggregator: Assign name and offsets only once in a loop drivers/gpio/gpio-aggregator.c | 110 +++++++++++++++++---------------- 1 file changed, 57 insertions(+), 53 deletions(-) -- 2.27.0