On Fri, Jul 17, 2020 at 4:02 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Erm, it does not even compile: > > drivers/gpio/gpio-crystalcove.c: In function ‘crystalcove_gpio_probe’: > drivers/gpio/gpio-crystalcove.c:357:10: error: ‘ch’ undeclared (first use in this function); did you mean ‘cg’? > 357 | girq = &ch->chip.irq; > | ^~ > | cg > drivers/gpio/gpio-crystalcove.c:357:10: note: each undeclared identifier is reported only once for each function it appears in > > I've fixed this up locally. Thanks, the SOC_PMIC isn't in the Intel default build, and you know me and Intel ... Sorry for that. Yours, Linus Walleij