On 16/07/2020 14:42:31+0100, Lee Jones wrote: > > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > > > index 9c52130876597..37997e5ab0538 100644 > > > --- a/drivers/pinctrl/pinctrl-at91.c > > > +++ b/drivers/pinctrl/pinctrl-at91.c > > > @@ -22,6 +22,7 @@ > > > #include <linux/pinctrl/pinmux.h> > > > /* Since we request GPIOs from ourself */ > > > #include <linux/pinctrl/consumer.h> > > > +#include <linux/platform_data/atmel.h> > > > > > > #include "pinctrl-at91.h" > > > #include "core.h" > > > diff --git a/include/linux/platform_data/atmel.h b/include/linux/platform_data/atmel.h > > > index 99e6069c5fd89..666ef482ea8c0 100644 > > > --- a/include/linux/platform_data/atmel.h > > > +++ b/include/linux/platform_data/atmel.h > > > > The plan is to get rid of that file so you should probably find a better > > location. > > Suggestions welcome. > Something like include/soc/at91/pm.h so we can also move at91_suspend_entering_slow_clock there and then kill platform_data/atmel.h. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com