Re: [PATCH] gpiolib: Add some warn print for easier to debug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 9, 2020 at 4:27 PM Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
> On Tue, Jul 7, 2020 at 5:09 PM mnlife <mnlife@xxxxxxxxxxx> wrote:

...

> > +               if (size >= sizeof(prop_name))
> > +                       dev_warn(dev, "prop_name %s is truncated with size %d\n",
> > +                                prop_name, size);

> To me this isn't a reason for a warning. If anything, this should
> simply be documented (if it's not already).

+1. This can only be useful in the development cycle.

CONFIG_DEBUG_GPIO easily catches this as well.


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux