08.07.2020 11:47, Andy Shevchenko пишет: > On Wed, Jul 8, 2020 at 11:29 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: >> >> Let's move the virq variable declaration to a top-level scope just to >> make the code a bit more visually appealing. > > To me it sounds like unneeded churn, but it's up to maintainers. > I agree that this is an unnecessary change, but I couldn't resist :) Alright, I'll skip the patches 3-5 in the v2. Thank you very much for the review!
Re: [PATCH v1 5/5] gpio: max77620: Move variable declaration
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 5/5] gpio: max77620: Move variable declaration
- From: Dmitry Osipenko <digetx@xxxxxxxxx>
- Date: Wed, 8 Jul 2020 12:24:18 +0300
- In-reply-to: <CAHp75VeMhb6BH9LnZxM+_-6nNzDErKN70T_QuuuW_dmLwcpoHg@mail.gmail.com>
- References: <20200708082634.30191-1-digetx@gmail.com> <20200708082634.30191-6-digetx@gmail.com> <CAHp75VeMhb6BH9LnZxM+_-6nNzDErKN70T_QuuuW_dmLwcpoHg@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0
- References:
- [PATCH v1 0/5] Improvements for MAX77620 GPIO driver
- From: Dmitry Osipenko
- [PATCH v1 5/5] gpio: max77620: Move variable declaration
- From: Dmitry Osipenko
- Re: [PATCH v1 5/5] gpio: max77620: Move variable declaration
- From: Andy Shevchenko
- [PATCH v1 0/5] Improvements for MAX77620 GPIO driver
- Prev by Date: Re: [PATCH 05/14] dt-bindings: power: renesas,rcar-sysc: Document r8a774e1 SYSC binding
- Next by Date: Re: [PATCH 06/14] dt-bindings: power: Add r8a774e1 SYSC power domain definitions
- Previous by thread: Re: [PATCH v1 5/5] gpio: max77620: Move variable declaration
- Next by thread: [PATCH v1 2/5] gpio: max77620: Replace 8 with MAX77620_GPIO_NR
- Index(es):
 |