On 2020-07-07 5:09 a.m., Linus Walleij wrote:
On Thu, Jun 11, 2020 at 6:51 PM Robert Hancock <hancock@xxxxxxxxxxxxx> wrote:
Adds interrupt support to the Xilinx GPIO driver so that rising and
falling edge line events can be supported. Since interrupt support is
an optional feature in the Xilinx IP, the driver continues to support
devices which have no interrupt provided.
These changes are based on a patch in the Xilinx Linux Git tree,
"gpio: xilinx: Add irq support to the driver" from Srinivas Neeli, but
include a number of fixes and improvements such as supporting both
rising and falling edge events.
Signed-off-by: Robert Hancock <hancock@xxxxxxxxxxxxx>
---
Changes from v1: Changed platform_get_irq to platform_get_irq_optional
Looks good to me, two questions:
- Can you make sure that this applies to the GPIO "devel" branch
that has the previous changes from Srinivas.
I confirmed it applies without conflicts and builds on that branch - it
doesn't appear that it has any changes to this driver that were not in
the version I submitted against.
- Can we get a Tested-by or at least ACK from Srinivas?
This driver currently lacks a maintainer. I would be very happy if
Srinivas or Robert or both would send a patch to add you as
maintainer(s) in the MAINTAINERS file, and would also like
Michal to to ACK that so everyone is happy.
Probably Srinivas or someone from Xilinx should be the primary
maintainer of this driver, but I could add myself in if they don't..
Yours,
Linus Walleij
--
Robert Hancock
Senior Hardware Designer
SED Systems, a division of Calian Ltd.
Email: hancock@xxxxxxxxxxxxx
