Re: [PATCH v3 1/2] gpio: add GPO driver for PCA9570

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-07-01 06:30, Andy Shevchenko wrote:
On Tue, Jun 30, 2020 at 7:08 PM Sungbo Eo <mans0n@xxxxxxxxxx> wrote:

NXP PCA9570 is 4-bit I2C GPO expander without interrupt functionality.
Its ports are controlled only by a data byte without register address.

As there is no other driver similar enough to be adapted for it, a new
driver is introduced here.


It looks good, but I would add ->get() to return buffered value.


Thanks, your suggestion was indeed valuable. I reworked the driver, please have a look.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux