Hello Miquel, On Tue, Jun 30, 2020 at 08:58:28AM +0200, Miquel Raynal wrote: > Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote on Mon, 29 Jun > 2020 21:50:44 +0200: > > > On Mon, Jun 29, 2020 at 04:08:44PM +0200, Miquel Raynal wrote: > > > Hello Uwe, Thierry, > > > > > > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Sun, 3 May 2020 > > > 12:54:53 +0200: > > > > > > > The MAX7313 chip is fully compatible with the PCA9535 on its basic > > > > functions but can also manage the intensity on each of its ports with > > > > PWM. Each output is independent and may be tuned with 16 values (4 > > > > bits per output). The period is always 32kHz, only the duty-cycle may > > > > be changed. One can use any output as GPIO or PWM. > > > > > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > > > --- > > > > > > Can I have a status on this patch please? > > > > > > If it was forgotten, I would be good to have it queued now, otherwise, > > > may I know the reason? > > > > You could reply to my feedback ... If you could say there: "What you > > want isn't possible" I'd count this as a strong indication to not ask to > > implement Andy's suggestion. (Even if this would be possible, I'm not > > sure this is a good idea, but still ...) > > Sorry for the misunderstanding, but I already replied twice to Andy > about this. Once in October, again in November, then I gave a shot to > the idea of splitting the drivers (GPIO vs. PWM) in January. So I > thought you were sharing your thoughts out loud but was not expecting > any specific feedback on it. Ah ok. Probably the discussion took too long already and was swapped out on my end. I will take a look once more later this week. One thing I noticed while skimming the patch was, that the added defines could make use of a nice prefix. MAX_PWM for example sounds quite generic. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
