Re: [PATCH v2 01/13] pinctrl: intel: Disable input and output buffer when switching to GPIO

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Mon, Jun 15, 2020 at 03:01:03PM +0300, Mika Westerberg wrote:
> On Fri, Jun 12, 2020 at 05:49:54PM +0300, Andy Shevchenko wrote:
> > It's possible scenario that pin has been in different mode, while
> > the respective GPIO register has a leftover output buffer enabled.
> > In such case when we request GPIO it will switch to GPIO mode, and
> > thus to output with unknown value, followed by switching to input
> > mode. This can produce a glitch on the pin.
> > 
> > Disable input and output buffer when switching to GPIO to avoid
> > potential glitches.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> 
> There was a minor comment on one patch but other than that this looks
> good.

I will apply patches to my review and testing queue soon, but I will reconsider
few of them (for_each_requested_gpio() helper and its use) for v2.

> For the whole series,
> 
> Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Thanks!

-- 
With Best Regards,
Andy Shevchenko