On Sat, Jun 6, 2020 at 5:09 PM gaurav singh <gaurav1086@xxxxxxxxx> wrote: > The pdata is already checked for its validity above: > > if (!pdata) { > dev_dbg(&client->dev, "no platform data\n"); > return -EINVAL; > } > > So no need to check again. Hence remove the if (pdata) part. Please find the patch below. Please send the patch as a single main using git send-email. For further help see: Documentation/process/email-clients.rst Yours, Linus Walleij