Re: [PATCH] gpio:asm28xx-18xx: new driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Richard,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on gpio/for-next]
[also build test WARNING on v5.7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Richard-Hsu/gpio-asm28xx-18xx-new-driver/20200601-160444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/gpio/gpio-asm28xx-18xx.c:69:6: warning: no previous prototype for 'pci_config_pm_runtime_get' [-Wmissing-prototypes]
69 | void pci_config_pm_runtime_get(struct pci_dev *pdev)
|      ^~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/gpio/gpio-asm28xx-18xx.c:91:6: warning: no previous prototype for 'pci_config_pm_runtime_put' [-Wmissing-prototypes]
91 | void pci_config_pm_runtime_put(struct pci_dev *pdev)
|      ^~~~~~~~~~~~~~~~~~~~~~~~~

vim +/pci_config_pm_runtime_get +69 drivers/gpio/gpio-asm28xx-18xx.c

    68	
  > 69	void pci_config_pm_runtime_get(struct pci_dev *pdev)
    70	{
    71		struct device *dev = &pdev->dev;
    72		struct device *parent = dev->parent;
    73	
    74		if (parent)
    75			pm_runtime_get_sync(parent);
    76		pm_runtime_get_noresume(dev);
    77		/*
    78		 * pdev->current_state is set to PCI_D3cold during suspending,
    79		 * so wait until suspending completes
    80		 */
    81		pm_runtime_barrier(dev);
    82		/*
    83		 * Only need to resume devices in D3cold, because config
    84		 * registers are still accessible for devices suspended but
    85		 * not in D3cold.
    86		 */
    87		if (pdev->current_state == PCI_D3cold)
    88			pm_runtime_resume(dev);
    89	}
    90	
  > 91	void pci_config_pm_runtime_put(struct pci_dev *pdev)
    92	{
    93		struct device *dev = &pdev->dev;
    94		struct device *parent = dev->parent;
    95	
    96		pm_runtime_put(dev);
    97		if (parent)
    98			pm_runtime_put_sync(parent);
    99	}
   100	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux