> From: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> Sent: Sunday, May 31, 2020 4:50 AM
>
> 'pinctrl_unregister()' should not be called to undo
> 'devm_pinctrl_register_and_init()', it is already handled by the framework.
>
> This simplifies the error handling paths of the probe function.
> The 'imx_free_resources()' can be removed as well.
>
> Fixes: a51c158bf0f7 ("pinctrl: imx: use radix trees for groups and functions")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
Reviewed-by: Dong Aisheng <aisheng.dong@xxxxxxx>
Regards
Aisheng
RE: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: RE: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
- From: Aisheng Dong <aisheng.dong@xxxxxxx>
- Date: Mon, 1 Jun 2020 10:16:19 +0000
- Accept-language: zh-CN, en-US
- In-reply-to: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr>
- References: <20200530204955.588962-1-christophe.jaillet@wanadoo.fr>
- References:
- [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
- From: Christophe JAILLET
- [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
- Prev by Date: Re: [PATCH v4 2/2] gpio: pca953x: Override IRQ for one of the expanders on Galileo Gen 2
- Next by Date: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
- Previous by thread: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
- Next by thread: Re: [PATCH] pinctrl: freescale: imx: Fix an error handling path in 'imx_pinctrl_probe()'
- Index(es):
 |