On Tue, May 26, 2020 at 3:11 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Tue, May 26, 2020 at 08:31:01AM +0300, Mika Westerberg wrote: > > On Mon, May 25, 2020 at 10:08:45PM +0300, Andy Shevchenko wrote: > > ... > > > > + dev_info(dev, "Applying ACPI interrupt quirk (GPIO %d)\n", pin); > > > + return gpiod_to_irq(gpio_to_desc(pin)); > > > > You need to request the GPIO as well, I missed that from my example. > > How? I can't find a function to request GPIO by its descriptor in > include/linux/gpio/*. If a gpiochip need to request one of its own GPIOs it should use gpiochip_request_own_desc() but I don't know if you have all info at hand to use that in this driver. Yours, Linus Walleij