Re: [PATCH] gpio:gpio-asm28xx-18xx: new driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Richard,

thanks for your patch!

Next time you resend, please include the PCI maintainer
and the PCI mailing list on the To: line.

Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
linux-pci@xxxxxxxxxxxxxxx

This is because I do not understand the use of some PCI-specific
accessors in this driver and what applies to them.

On Tue, May 26, 2020 at 12:44 PM Richard Hsu <saraon640529@xxxxxxxxx> wrote:

> Hi Bartosz Golaszewski and Linux Walleij
>   Sorry!I don't know why it diff against a patch in old repo.
> I create a new git repo and re-process it.
> I have modified it according to your suggestions.And our device
> is similar as AMD South Bridge(amd8111),then i just take
> gpio-amd8111.c in kernel driver source as reference.
> It says that we can't use plain pci_driver mechanism,as the device
> is really a multiple function device,main driver that binds to the
> pci_device is a bus driver.It seems reasonable,then i follow it.
>
> Signed-off-by: Richard Hsu <saraon640529@xxxxxxxxx>

>  patch | 314 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

This is still very weird for me.

How do you create this patch? I will not be able to apply this.

>  1 file changed, 314 insertions(+)
>  create mode 100644 patch
>
> diff --git a/patch b/patch
> index 0000000..220a8cf
> --- /dev/null
> +++ b/patch
> @@ -0,0 +1,314 @@
> +diff -uprN -X linux-5.7.0-rc6/Documentation/dontdiff linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c
> +--- linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c   1970-01-01 08:00:00.000000000 +0800
> ++++ linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c     2020-05-26 10:41:11.401349769 +0800
> +@@ -0,0 +1,281 @@
> ++// SPDX-License-Identifier: GPL-2.0-only
> ++/*
> ++ * Asmedia 28xx/18xx GPIO driver
> ++ *
> ++ * Copyright (C) 2020 ASMedia Technology Inc.
> ++ * Author: Richard Hsu <Richard_Hsu@xxxxxxxxxxxxxx>
> ++ */

You see all these double-++ things, they mean that this is a diff
of a patch so a patch of a patch. Something is really odd with how
you generate this patch.

Sending the thing in your root directory called "patch" instead of
generating this diff is better but preferably check your file into
git and generate the patch from git using the git format-patch
command.

If you're not best friends with git I don't blame you, just send
the patch then, but please not a diff of a patch, I can't deal with that.

Yours,
Linus Walleij