Re: [PATCH] gpio:gpio-asm28xx-18xx: new driver

[Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>]

wt., 26 maj 2020 o 10:15 Richard Hsu <saraon640529@xxxxxxxxx> napisał(a):
>
> Hi Bartosz Golaszewski and Linux Walleij,
>   Thanks for your reply.I have modified it according to your
> suggestions.And our device is silmilar as AMD South Bridge(amd8111),
> then i just take gpio-amd8111.c in kernel driver source as reference.
> It says that we can't use plain pci_driver mechanism, as the device
> is really a multiple function device,main driver that binds to the
> pci_device is a bus driver.It seems reasonable then i follow it.
>
> Signed-off-by: Richard Hsu <saraon640529@xxxxxxxxx>
> ---
>  patch | 44 +++++++++++++++++++++++---------------------
>  1 file changed, 23 insertions(+), 21 deletions(-)
>
> diff --git a/patch b/patch
> index a713f91..220a8cf 100644
> --- a/patch
> +++ b/patch
> @@ -1,7 +1,7 @@
>  diff -uprN -X linux-5.7.0-rc6/Documentation/dontdiff linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c
>  --- linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c   1970-01-01 08:00:00.000000000 +0800
> -+++ linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c     2020-05-22 11:55:13.736272177 +0800
> -@@ -0,0 +1,282 @@
> ++++ linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c     2020-05-26 10:41:11.401349769 +0800
> +@@ -0,0 +1,281 @@

Hi Richard,

please read Documentation/process/submitting-patches.rst in the linux
kernel source - it contains information on how to generate patches for
the mailing list. What you sent here is a diff against a patch and
it's useless for review-purposes.

Bart