Re: [PATCH] GPIO: Submit a new GPIO driver

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Richard!

Thanks for your patch!

On Mon, May 25, 2020 at 7:48 AM Richard Hsu <saraon640529@xxxxxxxxx> wrote:

> This driver provide GPIO functionality on Asmedia 28XX and 18XX PCI-E
> Bridge
>
> Signed-off-by: Richard Hsu <saraon640529@xxxxxxxxx>
> ---
>  patch | 312 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

There is something off with how this patch is generated.

> diff --git a/patch b/patch
> index 0000000..a713f91
> --- /dev/null
> +++ b/patch
> @@ -0,0 +1,312 @@
> +diff -uprN -X linux-5.7.0-rc6/Documentation/dontdiff linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c
> +--- linux-5.7.0-rc6/drivers/gpio/gpio-asm28xx-18xx.c   1970-01-01 08:00:00.000000000 +0800
> ++++ linux-5.7.0-rc6-patch/drivers/gpio/gpio-asm28xx-18xx.c     2020-05-22 11:55:13.736272177 +0800

Definitely off. Can't you just generate it from the git repo using
git format-patch HEAD^..HEAD or something?

> ++#include <linux/module.h>
> ++#include <linux/kernel.h>
> ++#include <linux/gpio/driver.h>
> ++#include <linux/pci.h>
> ++#include <linux/spinlock.h>
> ++#include <linux/pm_runtime.h>

#include <linux/bits.h>
Because you use BIT().

Maybe the PCI maintainer could look at how the pci_* accessors are
used in this driver because that beats me.

Yours.
Linus Walleij